Re: [PATCH 13/21] arch: don't memset(0) memory returned by memblock_alloc()

From
Geert Uytterhoeven <geert@linux-m68k.org>
Date
2019-01-16 14:17:36
Also in
linux-alpha, linux-arm-kernel, linux-devicetree, linux-mm, linux-s390, linux-um
Reply to
Mike Rapoport, 2019-01-16
On Wed, Jan 16, 2019 at 2:45 PM Mike Rapoport [off-list ref] wrote:
memblock_alloc() already clears the allocated memory, no point in doing it
twice.

Signed-off-by: Mike Rapoport <redacted>
 arch/m68k/mm/mcfmmu.c       | 1 -
For m68k part:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
quoted hunk ↗ jump to hunk
--- a/arch/m68k/mm/mcfmmu.c
+++ b/arch/m68k/mm/mcfmmu.c
@@ -44,7 +44,6 @@ void __init paging_init(void)
        int i;

        empty_zero_page = (void *) memblock_alloc(PAGE_SIZE, PAGE_SIZE);
-       memset((void *) empty_zero_page, 0, PAGE_SIZE);

        pg_dir = swapper_pg_dir;
        memset(swapper_pg_dir, 0, sizeof(swapper_pg_dir));
Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Thread (35 messages) 35 messages, 10 authors, last reply 2019-01-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help