Thread (19 messages) 19 messages, 5 authors, 2019-01-25

Re: [PATCH v2 7/9] arm64: kdump: No need to mark crashkernel pages manually PG_reserved

From: Catalin Marinas <catalin.marinas@arm.com>
Date: 2019-01-25 16:28:40
Also in: linux-arm-kernel, linux-mediatek, linux-mm, linux-riscv, linux-s390, lkml

On Mon, Jan 14, 2019 at 01:59:01PM +0100, David Hildenbrand wrote:
The crashkernel is reserved via memblock_reserve(). memblock_free_all()
will call free_low_memory_core_early(), which will go over all reserved
memblocks, marking the pages as PG_reserved.

So manually marking pages as PG_reserved is not necessary, they are
already in the desired state (otherwise they would have been handed over
to the buddy as free pages and bad things would happen).

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: James Morse <james.morse@arm.com>
Cc: Bhupesh Sharma <redacted>
Cc: David Hildenbrand <redacted>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Dave Kleikamp <redacted>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Rapoport <redacted>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>
Cc: Laura Abbott <redacted>
Cc: Greg Hackmann <redacted>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kristina Martsenko <redacted>
Cc: CHANDAN VN <redacted>
Cc: AKASHI Takahiro <redacted>
Cc: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
Signed-off-by: David Hildenbrand <redacted>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help