Re: ppc64le reliable stack unwinder and scheduled tasks
flat view
From: Josh Poimboeuf <hidden>
Date: 2019-01-14 17:09:40
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2019-01-17 · Re: ppc64le reliable stack unwinder and scheduled tasks · Segher Boessenkool <hidden>
- 2019-01-14 · Re: ppc64le reliable stack unwinder and scheduled tasks · Joe Lawrence <joe.lawrence@redhat.com>
- 2019-01-13 · Re: ppc64le reliable stack unwinder and scheduled tasks · Torsten Duwe <hidden>
- 2019-01-13 · Re: ppc64le reliable stack unwinder and scheduled tasks · Balbir Singh <bsingharora@gmail.com>
- 2019-01-12 · Re: ppc64le reliable stack unwinder and scheduled tasks · Segher Boessenkool <hidden>
On Mon, Jan 14, 2019 at 11:46:59AM -0500, Joe Lawrence wrote:
quoted hunk ↗ jump to hunk
@@ -158,11 +158,21 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk, return 1; /* invalid backlink, too far up. */ } + /* We can only trust the bottom frame's backlink, the rest + * of the frame may be uninitialized, continue to the next. */ + if (firstframe--) + goto next;
Won't this decrement firstframe on every iteration, so when firstframe is 0, it will decrement it to -1, causing it to 'goto next' on all future iterations? -- Josh