Thread (7 messages) 7 messages, 2 authors, 2019-01-08

RE: [PATCH 2/3] powerpc/dts/fsl: t4240rdb: use the Cortina PHY driver compatible

From: Camelia Alexandra Groza <hidden>
Date: 2019-01-08 14:07:16
Also in: linux-devicetree, lkml

-----Original Message-----
From: Scott Wood <oss@buserror.net>
Sent: Saturday, December 22, 2018 06:07
To: Camelia Alexandra Groza <redacted>;
robh+dt@kernel.org; mark.rutland@arm.com; benh@kernel.crashing.org
Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
paulus@samba.org; linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/3] powerpc/dts/fsl: t4240rdb: use the Cortina PHY
driver compatible

On Wed, 2018-07-18 at 14:46 +0300, Camelia Groza wrote:
quoted
The Cortina PHY requires the use of the dedicated Cortina PHY driver
instead of the generic one.

Signed-off-by: Camelia Groza <redacted>
---
 arch/powerpc/boot/dts/fsl/t4240rdb.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/boot/dts/fsl/t4240rdb.dts
b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
index 15eb0a3..a56a705 100644
--- a/arch/powerpc/boot/dts/fsl/t4240rdb.dts
+++ b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
@@ -267,22 +267,22 @@

 			mdio@fd000 {
 				xfiphy1: ethernet-phy@10 {
-					compatible = "ethernet-phy-
ieee802.3-
quoted
c45";
+					compatible = "ethernet-phy-
id13e5.1002";
 					reg = <0x10>;
 				};

 				xfiphy2: ethernet-phy@11 {
-					compatible = "ethernet-phy-
ieee802.3-
quoted
c45";
+					compatible = "ethernet-phy-
id13e5.1002";
 					reg = <0x11>;
 				};

 				xfiphy3: ethernet-phy@13 {
-					compatible = "ethernet-phy-
ieee802.3-
quoted
c45";
+					compatible = "ethernet-phy-
id13e5.1002";
 					reg = <0x13>;
 				};

 				xfiphy4: ethernet-phy@12 {
-					compatible = "ethernet-phy-
ieee802.3-
quoted
c45";
+					compatible = "ethernet-phy-
id13e5.1002";
 					reg = <0x12>;
 				};
 			};
I get crashes on boot when using a dtb with this change:
Hi

Sorry for the late replay. I was on vacation. I'm looking into it.

Regards,
Camelia
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help