Re: [PATCH v2 2/3] powerpc: Discard dynsym section for !PPC32

On Wed, 5 Dec 2018 at 04:11, Segher Boessenkool
[off-list ref] wrote:

On Tue, Dec 04, 2018 at 11:24:28AM +1030, Joel Stanley wrote:

quoted

Alan Modra [off-list ref] explains:

 > Likely you could discard .interp > and .dynstr too, and .dynsym when
 > !CONFIG_PPC32.

Discarding of interp and dynstr happened in a previous patch. The dynsym
cleanup was a bit less straightforward, so it gets it's own patch.

quoted

diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S
index 6570209b0671..2c93a420f456 100644
--- a/arch/powerpc/kernel/vmlinux.lds.S
+++ b/arch/powerpc/kernel/vmlinux.lds.S

@@ -266,14 +266,13 @@ SECTIONS
      }
 #ifdef CONFIG_RELOCATABLE
      . = ALIGN(8);
+#ifdef CONFIG_PPC32
      .dynsym : AT(ADDR(.dynsym) - LOAD_OFFSET)
      {
-#ifdef CONFIG_PPC32
              __dynamic_symtab = .;
-#endif
              *(.dynsym)
      }
-     .dynstr : AT(ADDR(.dynstr) - LOAD_OFFSET) { *(.dynstr) }

So this last line belongs in the previous patch then, right?

Correct. Good catch.