Thread (79 messages) 79 messages, 7 authors, 2019-01-08

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

flat view

From: Finn Thain <hidden>
Date: 2018-12-30 21:44:13
Also in: linux-scsi, lkml

On Sun, 30 Dec 2018, James Bottomley wrote:
That said, as has been pointed out, the current #ifdef has a failing 
corner case when both are modular (because the code should then be 
included).  The runtime macro that correctly expresses this is 
IS_REACHABLE(CONFIG_NVRAM).
No, in the case of CONFIG_NVRAM=m, the conditional code is deliberately 
excluded. This is discussed in the patch description. The convention on 
PPC32 is that device drivers drop support for NVRAM in this situation. 

I've adopted the PPC32 convention here because M68K drivers and PPC32 
drivers have to co-exist (I'm thinking of valkyriefb, but there are other 
examples).

-- 
James
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help