Re: [PATCH] powerpc/83xx: handle machine check caused by watchdog timer

Hi Christophe,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.20-rc7 next-20181218]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Christophe-Leroy/powerpc-83xx-handle-machine-check-caused-by-watchdog-timer/20181210-222612
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-mpc83xx_defconfig (attached as .config)
compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   arch/powerpc//platforms/83xx/misc.c: In function 'machine_check_83xx':

quoted

arch/powerpc//platforms/83xx/misc.c:162:6: error: implicit declaration of function 'debugger_fault_handler' [-Werror=implicit-function-declaration]

     if (debugger_fault_handler(regs))
         ^~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/debugger_fault_handler +162 arch/powerpc//platforms/83xx/misc.c

   153	
   154	int machine_check_83xx(struct pt_regs *regs)
   155	{
   156		u32 mask = 1 << (31 - IPIC_MCP_WDT);
   157	
   158		if (!(regs->msr & SRR1_MCE_MCP) || !(ipic_get_mcp_status() & mask))
   159			return machine_check_generic(regs);
   160		ipic_clear_mcp_status(mask);
   161	
 > 162		if (debugger_fault_handler(regs))

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation