Thread (5 messages) flat view 5 messages, 4 authors, 2018-12-06

Re: [PATCH] ASoC: Use of_node_name_eq for node name comparisons

From: Rob Herring <robh@kernel.org>
Date: 2018-12-06 13:34:35
Also in: alsa-devel, linux-devicetree, lkml

On Wed, Dec 5, 2018 at 7:53 PM Nicolin Chen [off-list ref] wrote:
Hi Rob,

On Thu, Dec 6, 2018 at 3:51 AM Rob Herring [off-list ref] wrote:
quoted
Convert string compares of DT node names to use of_node_name_eq helper
instead. This removes direct access to the node name pointer.

For the FSL ASoC card, the full node names appear to be "ssi", "esai",
and "sai", so there's not any reason to use strstr and of_node_name_eq
I am not quite sure about the replacement of strstr.
IIRC, a node name in fsl dts might appear to be "ssi@xxxx".
That will work fine. Unit-addresses are not part of the node name for
the comparison.
I am currently out of town so cannot verify the patch.

Fabio, would it be possible for you to run a boot test?

Thanks
Nicolin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help