Thread (4 messages) flat view 4 messages, 2 authors, 2018-12-22

Re: [PATCH] arch/powerpc: Use dma_zalloc_coherent

From: Sabyasachi Gupta <hidden>
Date: 2018-12-05 04:42:10
Also in: lkml

On Mon, Nov 5, 2018 at 7:52 AM Sabyasachi Gupta
[off-list ref] wrote:
Replaced dma_alloc_coherent + memset with dma_zalloc_coherent

Signed-off-by: Sabyasachi Gupta <redacted>
Any comment on this patch?
quoted hunk ↗ jump to hunk
---
 arch/powerpc/sysdev/fsl_rmu.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_rmu.c b/arch/powerpc/sysdev/fsl_rmu.c
index 88b35a3d..8b0ebf3 100644
--- a/arch/powerpc/sysdev/fsl_rmu.c
+++ b/arch/powerpc/sysdev/fsl_rmu.c
@@ -756,15 +756,13 @@ fsl_open_outb_mbox(struct rio_mport *mport, void *dev_id, int mbox, int entries)
        }

        /* Initialize outbound message descriptor ring */
-       rmu->msg_tx_ring.virt = dma_alloc_coherent(priv->dev,
+       rmu->msg_tx_ring.virt = dma_zalloc_coherent(priv->dev,
                                rmu->msg_tx_ring.size * RIO_MSG_DESC_SIZE,
                                &rmu->msg_tx_ring.phys, GFP_KERNEL);
        if (!rmu->msg_tx_ring.virt) {
                rc = -ENOMEM;
                goto out_dma;
        }
-       memset(rmu->msg_tx_ring.virt, 0,
-                       rmu->msg_tx_ring.size * RIO_MSG_DESC_SIZE);
        rmu->msg_tx_ring.tx_slot = 0;

        /* Point dequeue/enqueue pointers at first entry in ring */
--
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help