Thread (8 messages) flat view 8 messages, 3 authors, 2018-11-12

Re: [PATCH] powerpc/math-emu: Fix building with clang

From: Nick Desaulniers <ndesaulniers@google.com>
Date: 2018-11-12 19:19:31

On Mon, Nov 12, 2018 at 3:33 AM Joel Stanley [off-list ref] wrote:
quoted
On Thu, Nov 1, 2018 at 8:37 PM Joel Stanley [off-list ref] wrote:
quoted
  arch/powerpc/math-emu/fnmsub.c:46:2: error: invalid use of a cast in a
  inline asm context requiring an l-value: remove the cast or build with
  -fheinous-gnu-extensions
./arch/powerpc/include/asm/sfp-machine.h:283:27: note: expanded from
macro 'sub_ddmmss'
               : "=r" ((USItype)(sh)),                                  \
                       ~~~~~~~~~~^~~
Eek, I can of think that add_ssaaaa(), sub_ddmmss(), and umul_ppmm()
should be rewritten from the form:

asm("..." : "=r" (USItype)(arg) : ...);

to the form:

USItype temp = (USItype) arg;
asm("..." : "=r" (temp) : ...);
arg = (typeof(arg)) temp;

Rather than the flag being added.
-- 
Thanks,
~Nick Desaulniers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help