Thread (29 messages) 29 messages, 5 authors, 2018-12-12

Re: [PATCH 01/10] perf/core: Add macro to test for event exclusion flags

From: Andrew Murray <hidden>
Date: 2018-11-23 14:32:17
Also in: linux-alpha, linux-arm-kernel, lkml

On Tue, Nov 20, 2018 at 10:28:34PM +1100, Michael Ellerman wrote:
Andrew Murray [off-list ref] writes:
quoted
Add a macro that tests if any of the perf event exclusion flags
are set on a given event.

Signed-off-by: Andrew Murray <redacted>
---
 include/linux/perf_event.h | 9 +++++++++
 1 file changed, 9 insertions(+)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 53c500f..89ee7fa 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -1004,6 +1004,15 @@ perf_event__output_id_sample(struct perf_event *event,
 extern void
 perf_log_lost_samples(struct perf_event *event, u64 lost);
 
+static inline bool event_has_exclude_flags(struct perf_event *event)
+{
+	struct perf_event_attr *attr = &event->attr;
+
+	return attr->exclude_idle || attr->exclude_user ||
+	       attr->exclude_kernel || attr->exclude_hv ||
+	       attr->exclude_guest || attr->exclude_host;
+}
Sorry to be a total PITA, but using "flags" plural suggests that it only
returns true if there is more than one exclude flag set.

A better name would be event_has_exclude_flag() or maybe
event_has_any_exclude_flag().

If you're doing a respin anyway it'd be nice to fix the name, but
obviously it's not high priority.
No problem - I'll go with event_has_any_exclude_flag.

Thanks,

Andrew Murray
cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help