Thread (20 messages) 20 messages, 5 authors, 2018-12-22

Re: [PATCH v2] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2018-11-16 12:42:30
Also in: lkml

Elvira Khabirova [off-list ref] writes:
Arch code should use tracehook_*() helpers, as documented
in include/linux/tracehook.h.
Thanks.

It probably also should have a comment explaining why we're ignoring the
return value and why that's OK.

cheers
quoted hunk ↗ jump to hunk
Fixes: 5521eb4bca2d ("powerpc/ptrace: Add support for PTRACE_SYSEMU")
Signed-off-by: Elvira Khabirova <redacted>
---
 arch/powerpc/kernel/ptrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
index afb819f4ca68..d79d907f9acc 100644
--- a/arch/powerpc/kernel/ptrace.c
+++ b/arch/powerpc/kernel/ptrace.c
@@ -3266,7 +3266,7 @@ long do_syscall_trace_enter(struct pt_regs *regs)
 	user_exit();
 
 	if (test_thread_flag(TIF_SYSCALL_EMU)) {
-		ptrace_report_syscall(regs);
+		(void) tracehook_report_syscall_entry(regs);
 		/*
 		 * Returning -1 will skip the syscall execution. We want to
 		 * avoid clobbering any register also, thus, not 'gotoing'
-- 
2.19.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help