Re: [PATCH v2 1/2] kbuild: add -no-integrated-as Clang option unconditionally
From: Nick Desaulniers <ndesaulniers@google.com>
Date: 2018-11-09 18:09:08
Also in:
linux-kbuild, lkml
On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada [off-list ref] wrote:
quoted hunk ↗ jump to hunk
We are still a way off the Clang's integrated assembler support for the kernel. Hence, -no-integrated-as is mandatory to build the kernel with Clang. If you had an ancient version of Clang that does not recognize this option, you would not be able to compile the kernel anyway. Signed-off-by: Masahiro Yamada <redacted> --- Changes in v2: - New patch Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/Makefile b/Makefile index 93315eb..da11700 100644 --- a/Makefile +++ b/Makefile@@ -497,8 +497,8 @@ CLANG_GCC_TC := --gcc-toolchain=$(GCC_TOOLCHAIN) endif KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX) KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX) -KBUILD_CFLAGS += $(call cc-option, -no-integrated-as) -KBUILD_AFLAGS += $(call cc-option, -no-integrated-as) +KBUILD_CFLAGS += -no-integrated-as +KBUILD_AFLAGS += -no-integrated-as
Sorry for the delay in review. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
endif RETPOLINE_CFLAGS_GCC := -mindirect-branch=thunk-extern -mindirect-branch-register -- 2.7.4
-- Thanks, ~Nick Desaulniers