We are still a way off the Clang's integrated assembler support for
the kernel. Hence, -no-integrated-as is mandatory to build the kernel
with Clang. If you had an ancient version of Clang that does not
recognize this option, you would not be able to compile the kernel
anyway.
Signed-off-by: Masahiro Yamada <redacted>
---
Changes in v2:
- New patch
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
-no-integrated-as into a single variable CLANG_FLAGS so that it can be
easily reused in other parts of Makefile.
Signed-off-by: Masahiro Yamada <redacted>
---
Changes in v2:
- Use := flavor instead of = because $(CLANG_FLAGS) is expanded soon anyway
Makefile | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
From: Nick Desaulniers <ndesaulniers@google.com> Date: 2018-11-09 18:09:08
On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada
[off-list ref] wrote:
quoted hunk
We are still a way off the Clang's integrated assembler support for
the kernel. Hence, -no-integrated-as is mandatory to build the kernel
with Clang. If you had an ancient version of Clang that does not
recognize this option, you would not be able to compile the kernel
anyway.
Signed-off-by: Masahiro Yamada <redacted>
---
Changes in v2:
- New patch
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Nick Desaulniers <ndesaulniers@google.com> Date: 2018-11-09 18:29:49
On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada
[off-list ref] wrote:
quoted hunk
Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
-no-integrated-as into a single variable CLANG_FLAGS so that it can be
easily reused in other parts of Makefile.
Signed-off-by: Masahiro Yamada <redacted>
---
Changes in v2:
- Use := flavor instead of = because $(CLANG_FLAGS) is expanded soon anyway
Makefile | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
Thanks for this patch, Masahiro, it's a good simplification.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Would you mind waiting for a tested-by from Stefan, and maybe an ack
from Greg (added to cc)?
--
Thanks,
~Nick Desaulniers
On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada
[off-list ref] wrote:
quoted
Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
-no-integrated-as into a single variable CLANG_FLAGS so that it can be
easily reused in other parts of Makefile.
Signed-off-by: Masahiro Yamada <redacted>
---
Changes in v2:
- Use := flavor instead of = because $(CLANG_FLAGS) is expanded soon anyway
Makefile | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
Thanks for this patch, Masahiro, it's a good simplification.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Would you mind waiting for a tested-by from Stefan, and maybe an ack
from Greg (added to cc)?
On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann [off-list ref] wrote:
On 11/09/2018 10:29 AM, Nick Desaulniers wrote:
quoted
On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada
[off-list ref] wrote:
quoted
Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
-no-integrated-as into a single variable CLANG_FLAGS so that it can be
easily reused in other parts of Makefile.
Signed-off-by: Masahiro Yamada <redacted>
---
Changes in v2:
- Use := flavor instead of = because $(CLANG_FLAGS) is expanded soon anyway
Makefile | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
Thanks for this patch, Masahiro, it's a good simplification.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Would you mind waiting for a tested-by from Stefan, and maybe an ack
from Greg (added to cc)?
Acked-by: Greg Hackmann <redacted>
Thanks for your review!
So, how to organize this series, and Joel's one together?
I'd like Joel to use this series as a base for his work.
(https://lore.kernel.org/patchwork/patch/1006696/)
It will be much cleaner.
Shall I merge all the patches to kbuild tree, or
maybe will they go through powerpc tree?
--
Best Regards
Masahiro Yamada
From: Michael Ellerman <mpe@ellerman.id.au> Date: 2018-11-12 01:05:24
Masahiro Yamada [off-list ref] writes:
On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann [off-list ref] wrote:
quoted
On 11/09/2018 10:29 AM, Nick Desaulniers wrote:
quoted
On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada
[off-list ref] wrote:
quoted
Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
-no-integrated-as into a single variable CLANG_FLAGS so that it can be
easily reused in other parts of Makefile.
Signed-off-by: Masahiro Yamada <redacted>
---
Changes in v2:
- Use := flavor instead of = because $(CLANG_FLAGS) is expanded soon anyway
Makefile | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
Thanks for this patch, Masahiro, it's a good simplification.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Would you mind waiting for a tested-by from Stefan, and maybe an ack
from Greg (added to cc)?
Acked-by: Greg Hackmann <redacted>
Thanks for your review!
So, how to organize this series, and Joel's one together?
I'd like Joel to use this series as a base for his work.
(https://lore.kernel.org/patchwork/patch/1006696/)
It will be much cleaner.
Shall I merge all the patches to kbuild tree, or
maybe will they go through powerpc tree?
Joel's changes are fairly small so you may as well merge them along with
the rest of the series, if that's OK with you and Joel.
cheers
On Mon, Nov 12, 2018 at 10:05 AM Michael Ellerman [off-list ref] wrote:
Masahiro Yamada [off-list ref] writes:
quoted
On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann [off-list ref] wrote:
quoted
On 11/09/2018 10:29 AM, Nick Desaulniers wrote:
quoted
On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada
[off-list ref] wrote:
quoted
Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
-no-integrated-as into a single variable CLANG_FLAGS so that it can be
easily reused in other parts of Makefile.
Signed-off-by: Masahiro Yamada <redacted>
---
Changes in v2:
- Use := flavor instead of = because $(CLANG_FLAGS) is expanded soon anyway
Makefile | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
Thanks for this patch, Masahiro, it's a good simplification.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Would you mind waiting for a tested-by from Stefan, and maybe an ack
from Greg (added to cc)?
Acked-by: Greg Hackmann <redacted>
Thanks for your review!
So, how to organize this series, and Joel's one together?
I'd like Joel to use this series as a base for his work.
(https://lore.kernel.org/patchwork/patch/1006696/)
It will be much cleaner.
Shall I merge all the patches to kbuild tree, or
maybe will they go through powerpc tree?
Joel's changes are fairly small so you may as well merge them along with
the rest of the series, if that's OK with you and Joel.
OK, I will.
Joel,
If you send v2, I will merge it to kbuild tree.
Thanks.
--
Best Regards
Masahiro Yamada
From: Joel Stanley <joel@jms.id.au> Date: 2018-11-12 04:22:52
On Mon, 12 Nov 2018 at 13:59, Masahiro Yamada
[off-list ref] wrote:
On Mon, Nov 12, 2018 at 10:05 AM Michael Ellerman [off-list ref] wrote:
quoted
Masahiro Yamada [off-list ref] writes:
quoted
On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann [off-list ref] wrote:
quoted
On 11/09/2018 10:29 AM, Nick Desaulniers wrote:
quoted
On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada
[off-list ref] wrote:
quoted
Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
-no-integrated-as into a single variable CLANG_FLAGS so that it can be
easily reused in other parts of Makefile.
Signed-off-by: Masahiro Yamada <redacted>
---
Changes in v2:
- Use := flavor instead of = because $(CLANG_FLAGS) is expanded soon anyway
Makefile | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
Thanks for this patch, Masahiro, it's a good simplification.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Would you mind waiting for a tested-by from Stefan, and maybe an ack
from Greg (added to cc)?
Acked-by: Greg Hackmann <redacted>
Thanks for your review!
So, how to organize this series, and Joel's one together?
I'd like Joel to use this series as a base for his work.
(https://lore.kernel.org/patchwork/patch/1006696/)
It will be much cleaner.
Shall I merge all the patches to kbuild tree, or
maybe will they go through powerpc tree?
Joel's changes are fairly small so you may as well merge them along with
the rest of the series, if that's OK with you and Joel.
OK, I will.
Joel,
If you send v2, I will merge it to kbuild tree.
On Tue, Nov 6, 2018 at 12:06 PM Masahiro Yamada
[off-list ref] wrote:
We are still a way off the Clang's integrated assembler support for
the kernel. Hence, -no-integrated-as is mandatory to build the kernel
with Clang. If you had an ancient version of Clang that does not
recognize this option, you would not be able to compile the kernel
anyway.
Signed-off-by: Masahiro Yamada <redacted>
---
Applied to linux-kbuild.
quoted hunk
Changes in v2:
- New patch
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On Tue, Nov 6, 2018 at 12:06 PM Masahiro Yamada
[off-list ref] wrote:
Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
-no-integrated-as into a single variable CLANG_FLAGS so that it can be
easily reused in other parts of Makefile.
Signed-off-by: Masahiro Yamada <redacted>
---
Applied to linux-kbuild.
quoted hunk
Changes in v2:
- Use := flavor instead of = because $(CLANG_FLAGS) is expanded soon anyway
Makefile | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)