Re: [PATCH 2/4] mm: speed up mremap by 500x on large regions (v2)

From
Joel Fernandes <hidden>
Date
2018-10-25 02:13:53
Also in
kvmarm, linux-alpha, linux-mips, linux-mm, linux-riscv, linux-um
Reply to
Balbir Singh, 2018-10-24
On Wed, Oct 24, 2018 at 10:57:33PM +1100, Balbir Singh wrote:
[...]
quoted
quoted
+		pmd_t pmd;
+
+		new_ptl = pmd_lockptr(mm, new_pmd);

Looks like this is largely inspired by move_huge_pmd(), I guess a lot of
the code applies, why not just reuse as much as possible? The same comments
w.r.t mmap_sem helping protect against lock order issues applies as well.
I thought about this and when I looked into it, it seemed there are subtle
differences that make such sharing not worth it (or not possible).

 - Joel
Thread (26 messages) 26 messages, 7 authors, last reply 2018-10-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help