Thread (42 messages) 42 messages, 6 authors, 2018-10-17

Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2018-10-15 09:25:47
Also in: dri-devel, linux-arm-kernel, linux-block, linux-fbdev, lkml

LEROY Christophe [off-list ref] writes:
Michael Ellerman [off-list ref] a écrit :
quoted
Michael Ellerman [off-list ref] writes:
quoted
Christophe Leroy [off-list ref] writes:
quoted
Set PAGE_KERNEL directly in the caller and do not rely on a
hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set.

As already done for PPC64, use pgprot_cache() helpers instead of
_PAGE_XXX flags in PPC32 ioremap() derived functions.

Signed-off-by: Christophe Leroy <redacted>
Something in here is breaking my p5020ds (both 32-bit and 64-bit):
Oh duh.

That's because I didn't take patch 4.

It didn't have any acks, but I guess I'll just merge it rather than
breaking things.
Yes indeed. Maybe should I have followed it more carrefully to ensure  
it gets an ack.
That's OK, I should have paid more attention to what it was actually
doing, I thought it was just a cleanup.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help