Re: [PATCH] powerpc/xmon/ppc-opc: Use ARRAY_SIZE macro

On Tue, 2018-10-09 at 14:43 +1100, Michael Ellerman wrote:

Joe Perches [off-list ref] writes:

quoted

On Thu, 2018-10-04 at 19:10 +0200, Gustavo A. R. Silva wrote:

quoted

Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element.

[]

quoted

diff --git a/arch/powerpc/xmon/ppc-opc.c b/arch/powerpc/xmon/ppc-opc.c

[]

quoted

@@ -966,8 +966,7 @@ const struct powerpc_operand powerpc_operands[] =
   { 0xff, 11, NULL, NULL, PPC_OPERAND_SIGNOPT },
 };
 
-const unsigned int num_powerpc_operands = (sizeof (powerpc_operands)
-					   / sizeof (powerpc_operands[0]));
+const unsigned int num_powerpc_operands = ARRAY_SIZE(powerpc_operands);

It seems this is unused and could be deleted.

The code in this file is copied from binutils.

We don't want to needlessly diverge it.

I've said this before:

  https://lore.kernel.org/linuxppc-dev/874lfxjnzl.fsf@concordia.ellerman.id.au/ (local)

Don't expect people to remember this.

Is there some way we can blacklist this file from checkpatch, Coccinelle
etc?

Modify both to look for some specific tag
in a file and then update the scripts to
read the file when looking at patches too.

Otherwise, no.