Thread (8 messages) 8 messages, 6 authors, 2018-10-11

Re: [PATCH] memblock: stop using implicit alignement to SMP_CACHE_BYTES

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2018-10-05 04:02:08
Also in: linux-alpha, linux-arm-kernel, linux-m68k, linux-mips, linux-mm, linux-um, lkml

On Fri, 2018-10-05 at 00:07 +0300, Mike Rapoport wrote:
When a memblock allocation APIs are called with align = 0, the alignment is
implicitly set to SMP_CACHE_BYTES.

Replace all such uses of memblock APIs with the 'align' parameter explicitly
set to SMP_CACHE_BYTES and stop implicit alignment assignment in the
memblock internal allocation functions.

For the case when memblock APIs are used via helper functions, e.g. like
iommu_arena_new_node() in Alpha, the helper functions were detected with
Coccinelle's help and then manually examined and updated where appropriate.

The direct memblock APIs users were updated using the semantic patch below:
What is the purpose of this ? It sounds rather counter-intuitive...

Ben.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help