Thread (11 messages) 11 messages, 5 authors, 2018-09-30

Re: [PATCH v3 2/2] powerpc/64: add stack protector support

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2018-09-26 11:51:06
Also in: lkml

Christophe LEROY [off-list ref] writes:
Le 26/09/2018 =C3=A0 11:28, Segher Boessenkool a =C3=A9crit=C2=A0:
quoted
On Wed, Sep 26, 2018 at 09:58:30AM +0200, Christophe LEROY wrote:
quoted
Segher, any idea about this problem ?
=20
quoted
quoted
quoted
arch/powerpc/platforms/powermac/bootx_init.o: In function `bootx_prin=
tf':
quoted
quoted
quoted
quoted
/var/lib/jenkins-slave/workspace/snowpatch/snowpatch-linux-
sparse/linux/arch/powerpc/platforms/powermac/bootx_init.c:88:
undefined reference to `__stack_chk_fail_local'
=20
Are you building as PIC?  Are you linking libssp_nonshared.a?  Why not?
Spotted, thanks.

arch/powerpc/platforms/powermac/Makefile contains:

CFLAGS_bootx_init.o  		+=3D -fPIC
...
Or maybe stack protection on bootx_init doesn't make much sense and we=20
could just do the following ?

CFLAGS_bootx_init.o  		+=3D -fPIC $(call cc-option, -fno-stack-protector)
That would be fine by me.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help