Re: [PATCH v8 1/3] powerpc: Detect the presence of big-cores via "ibm,thread-groups"

On Fri, 2018-09-21 at 22:47 +0530, Gautham R Shenoy wrote:

Hello Michael,
=20
On Fri, Sep 21, 2018 at 01:02:45PM +1000, Michael Neuling wrote:

quoted

This doesn't compile for me with:
=20
arch/powerpc/kernel/smp.c: In function =E2=80=98smp_prepare_cpus=E2=80=

=99:

quoted

arch/powerpc/kernel/smp.c:812:23: error: =E2=80=98tg.threads_per_group=

=E2=80=99 may be used

quoted

uninitialized in this function [-Werror=3Dmaybe-uninitialized]
  struct thread_groups tg;
                       ^
arch/powerpc/kernel/smp.c:812:23: error: =E2=80=98tg.nr_groups=E2=80=99=

 may be used

quoted

uninitialized in this function [-Werror=3Dmaybe-uninitialized]
cc1: all warnings being treated as errors
/home/mikey/src/linux-ozlabs/scripts/Makefile.build:305: recipe for tar=

get

quoted

'arch/powerpc/kernel/smp.o' failed
=20

=20
I couldn't get this error with gcc 4.8.5 and 8.1.1 with
pseries_defconfig and powernv_defconfig with CONFIG_PPC_WERROR=3Dy.

I'm using 5.4.0 which is in Ubuntu 16.04 (LTS).

Does the following the following delta patch make it work?

Yep that fixes it, thanks.

Mikey