Re: [PATCH] powerpc/powernv/idle: Fix build error

Alexey Kardashevskiy [off-list ref] writes:

On 10/08/2018 17:10, Michael Ellerman wrote:

quoted

"Aneesh Kumar K.V" [off-list ref] writes:

quoted

Fix the below build error using strlcpy instead of strncpy

In function 'pnv_parse_cpuidle_dt',
    inlined from 'pnv_init_idle_states' at arch/powerpc/platforms/powernv/idle.c:840:7,
    inlined from '__machine_initcall_powernv_pnv_init_idle_states' at arch/powerpc/platforms/powernv/idle.c:870:1:
arch/powerpc/platforms/powernv/idle.c:820:3: error: 'strncpy' specified bound 16 equals destination size [-Werror=stringop-truncation]
   strncpy(pnv_idle_states[i].name, temp_string[i],
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    PNV_IDLE_NAME_LEN);

I'm curious why I haven't seen this? What compiler are you using?

gcc 8 does this.

Yeah you're right. It was hidden by another build failure in my build
scripts :/

cheers