Re: cxl: remove a dead branch
From: Mathieu Malaterre <hidden>
Date: 2018-08-13 11:25:44
Frederic, Could you double check with Michael what is now best to do. Thanks On Mon, Aug 13, 2018 at 1:23 PM Michael Ellerman [off-list ref] wrote:
On Thu, 2018-03-22 at 21:05:28 UTC, Mathieu Malaterre wrote:quoted
In commit 14baf4d9c739 ("cxl: Add guest-specific code") the following code was added: if (afu->crs_len < 0) { dev_err(&afu->dev, "Unexpected configuration record size value\n"); return -EINVAL; } However the variable `crs_len` is of type u64 and cannot be compared < 0. Remove the dead code section. Fix the following warning treated as error with W=1: ../drivers/misc/cxl/guest.c:919:19: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] Signed-off-by: Mathieu Malaterre <redacted>Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/e4ecafb14fd9cd77d8f4320af1922e cheers