Re: [PATCH v02] powerpc/mobility: Fix node detach/rename problem

Michael Bringmann [off-list ref] writes:

On 08/08/2018 09:02 AM, Michael Ellerman wrote:

quoted

Michael Bringmann [off-list ref] writes:

quoted

diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
index e245a88..efc9442 100644
--- a/arch/powerpc/platforms/pseries/mobility.c
+++ b/arch/powerpc/platforms/pseries/mobility.c

@@ -22,6 +22,9 @@
 #include <asm/rtas.h>
 #include "pseries.h"
 
+extern int of_free_phandle_cache(void);
+extern void of_populate_phandle_cache(void);

We don't do that, they should be in a header.

But that's a minor problem given that the patch doesn't compile, because
both those functions are static.

I am building against the latest 'linux-ppc' kernel.  It includes patch

OK you must be using the master branch.

Commit b9952b5218added5577e4a3443969bc20884cea9 Mon Sep 17 00:00:00 2001
From: Frank Rowand <redacted>
Date: Thu, 12 Jul 2018 14:00:07 -0700
Subject: of: overlay: update phandle cache on overlay apply and remove

That only landed in v4.18-rc6, so it's not in my next branch which is
where patches like this targeted for the next release are applied.

which makes the functions static.  I will rebuild and test with an
earlier version if you will specify which one.

No that's fine it will just have to wait until next and master are
merged before it can go in.

cheers