Re: [PATCH 2/2] powerpc/cpu: post the event cpux add/remove instead of online/offline during hotplug

Hi Pingfan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.18-rc7 next-20180802]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Pingfan-Liu/powerpc-cpuidle-dynamically-register-unregister-cpuidle_device-during-hotplug/20180803-151916
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allnoconfig (attached as .config)
compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   arch/powerpc/kernel/sysfs.c: In function 'unregister_ppc_cpu':

quoted

arch/powerpc/kernel/sysfs.c:1052:2: error: implicit declaration of function 'unregister_cpu'; did you mean 'register_cpu'? [-Werror=implicit-function-declaration]

     unregister_cpu(container_of(get_cpu_device(cpu),
     ^~~~~~~~~~~~~~
     register_cpu
   cc1: all warnings being treated as errors

vim +1052 arch/powerpc/kernel/sysfs.c

  1047	
  1048	int unregister_ppc_cpu(int cpu)
  1049	{
  1050		device_remove_file(&per_cpu(cpu_devices, cpu).dev,
  1051			&dev_attr_physical_id);

1052		unregister_cpu(container_of(get_cpu_device(cpu),

  1053			struct cpu, dev));
  1054		return 0;
  1055	}
  1056	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation