Thread (3 messages) flat view 3 messages, 3 authors, 2018-08-07
STALE2919d REVIEWED: 1 (0M)

1 review trailer.

[PATCH] misc: ibmvsm: Fix wrong assignment of return code

From: Bryant G. Ly <hidden>
Date: 2018-08-06 13:31:11
Also in: lkml
Subsystem: char and misc drivers, ibm power virtual management channel driver, the rest · Maintainers: Arnd Bergmann, Greg Kroah-Hartman, Brad Warrum, Ritu Agarwal, Linus Torvalds

From: "Bryant G. Ly" <redacted>

Currently the assignment is flipped and rc is always 0.

Signed-off-by: Bryant G. Ly <redacted>
Reviewed-by: Bradley Warrum <redacted>
---
 drivers/misc/ibmvmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c
index 8f82bb9..b8aaa68 100644
--- a/drivers/misc/ibmvmc.c
+++ b/drivers/misc/ibmvmc.c
@@ -2131,7 +2131,7 @@ static int ibmvmc_init_crq_queue(struct crq_server_adapter *adapter)
 	retrc = plpar_hcall_norets(H_REG_CRQ,
 				   vdev->unit_address,
 				   queue->msg_token, PAGE_SIZE);
-	retrc = rc;
+	rc = retrc;
 
 	if (rc == H_RESOURCE)
 		rc = ibmvmc_reset_crq_queue(adapter);
-- 
2.7.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help