[PATCH] powpc:feature: of_node_put is not needed after iterator.
From: zhong jiang <hidden>
Date: 2018-08-04 14:36:45
Also in:
lkml
Subsystem:
linux for power macintosh, linux for powerpc (32-bit and 64-bit), the rest · Maintainers:
Madhavan Srinivasan, Linus Torvalds
for_each_node_by_name iterators only exit normally when the loop cursor is NULL, So there is no point to call of_node_put. Signed-off-by: zhong jiang <redacted> --- arch/powerpc/platforms/powermac/feature.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
index 3f82cb2..4eb8cb3 100644
--- a/arch/powerpc/platforms/powermac/feature.c
+++ b/arch/powerpc/platforms/powermac/feature.c@@ -2889,10 +2889,8 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ /* On all machines, switch modem & serial ports off */ for_each_node_by_name(np, "ch-a") initial_serial_shutdown(np); - of_node_put(np); for_each_node_by_name(np, "ch-b") initial_serial_shutdown(np); - of_node_put(np); } void __init
--
1.7.12.4