Thread (22 messages) 22 messages, 6 authors, 2018-08-01

Re: [v4,01/11] macintosh/via-pmu: Fix section mismatch warning

flat view

From: Michael Ellerman <hidden>
Date: 2018-08-01 05:24:03
Also in: lkml

On Mon, 2018-07-02 at 08:21:18 UTC, Finn Thain wrote:
The pmu_init() function has the __init qualifier, but the ops struct
that holds a pointer to it does not. This causes a build warning.
The driver works fine because the pointer is only dereferenced early.

The function is so small that there's negligible benefit from using
the __init qualifier. Remove it to fix the warning, consistent with
the other ADB drivers.

Tested-by: Stan Johnson <redacted>
Signed-off-by: Finn Thain <redacted>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Series applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/73f4447d43484224d7abfba0d9468d

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help