Murilo Opsfelder Araujo [off-list ref] a =C3=A9crit=C2=A0:

Hi, Christophe.

On Fri, Jul 27, 2018 at 06:40:23PM +0200, LEROY Christophe wrote:

quoted

Murilo Opsfelder Araujo [off-list ref] a =C3=A9crit=C2=A0:

quoted

Simplify the message format by using REG_FMT as the register format.  =

This

quoted

quoted

avoids having two different formats and avoids checking for MSR_64BIT.

Are you sure it is what we want ?

Yes.

quoted

Won't it change the behaviour for a 32 bits app running on a 64bits kern=

el ?

In fact, this changes how many zeroes are prefixed when displaying=20=20
=20the registers
(%016lx vs. %08lx format).  For example, 32-bits userspace, 64-bits kerne=

l:

Indeed that's what I suspected. What is the real benefit of this=20=20
change=20? Why not keep the current format for 32bits userspace ? All=20=20
those=20leading zeroes are pointless to me.

before this series:
  [66475.002900] segv[4599]: unhandled signal 11 at 00000000 nip=20=20
=2010000420 lr 0fe61854 code 1

after this series:
  [   73.414535] segv[3759]: segfault (11) at 0000000000000000 nip=20=20
=200000000010000420 lr 000000000fe61854 code 1 in segv[10000000+10000]
  [   73.414641] segv[3759]: code: 4e800421 80010014 38210010=20=20
=207c0803a6 4bffff30 9421ffd0 93e1002c 7c3f0b78
  [   73.414665] segv[3759]: code: 39200000 913f001c 813f001c=20=20
=2039400001 <91490000> 39200000 7d234b78 397f0030

Have you spotted any other behaviour change?

Not as of today

Christophe

Cheers
Murilo