Re: [PATCH 1/2] mm/cma: remove unsupported gfp_mask parameter from cma_alloc()

On Tue 10-07-18 16:19:32, Joonsoo Kim wrote:

Hello, Marek.

2018-07-09 21:19 GMT+09:00 Marek Szyprowski [off-list ref]:

quoted

cma_alloc() function doesn't really support gfp flags other than
__GFP_NOWARN, so convert gfp_mask parameter to boolean no_warn parameter.

Although gfp_mask isn't used in cma_alloc() except no_warn, it can be used
in alloc_contig_range(). For example, if passed gfp mask has no __GFP_FS,
compaction(isolation) would work differently. Do you have considered
such a case?

Does any of cma_alloc users actually care about GFP_NO{FS,IO}?
-- 
Michal Hocko
SUSE Labs