Re: [v2 PATCH 0/5] powerpc/pseries: Machien check handler improvements.
From: Mahesh Jagannath Salgaonkar <hidden>
Date: 2018-06-07 16:33:06
On 06/07/2018 04:15 PM, Nicholas Piggin wrote:
On Thu, 07 Jun 2018 15:36:25 +0530 Mahesh J Salgaonkar [off-list ref] wrote:quoted
This patch series includes some improvement to Machine check handler for pseries. Patch 1 fixes an issue where machine check handler crashes kernel while accessing vmalloc-ed buffer while in nmi context. Patch 3 dumps the SLB contents on SLB MCE errors to improve the debugability. Patch 4 display's the MCE error details on console. Change in V2: - patch 4: Display additional info (NIP and task info) in MCE error details. - patch 5: Fix endain bug while restoring of r3 in MCE handler. --- Mahesh Salgaonkar (5): powerpc/pseries: convert rtas_log_buf to linear allocation. powerpc/pseries: Define MCE error event section. powerpc/pseries: Dump and flush SLB contents on SLB MCE errors. powerpc/pseries: Display machine check error details. powerpc/pseries: Fix endainness while restoring of r3 in MCE handler.These look good, should patch 5 be moved to patch 2 and the first 2 patches marked for stable?
Yup. Will move patch 5 to 2nd position.
Do you also plan to dump SLB contents for bare metal MCEs?
Yes. That's the plan. Will do that separately. Thanks, -Mahesh.