Re: [RFC PATCH -tip v5 18/27] powerpc/kprobes: Don't call the ->break_handler() in arm kprobes code

On Thu, 07 Jun 2018 22:07:26 +0530
"Naveen N. Rao" [off-list ref] wrote:

Masami Hiramatsu wrote:

quoted

On Thu, 07 Jun 2018 17:07:00 +0530
"Naveen N. Rao" [off-list ref] wrote:

quoted

Masami Hiramatsu wrote:

quoted

Don't call the ->break_handler() from the arm kprobes code,

					    ^^^ powerpc

quoted

because it was only used by jprobes which got removed.

This also makes skip_singlestep() a static function since
only ftrace-kprobe.c is using this function.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <redacted>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: "Naveen N. Rao" <redacted>
Cc: linuxppc-dev@lists.ozlabs.org
---
 arch/powerpc/include/asm/kprobes.h   |   10 ----------
 arch/powerpc/kernel/kprobes-ftrace.c |   16 +++-------------
 arch/powerpc/kernel/kprobes.c        |   31 +++++++++++--------------------
 3 files changed, 14 insertions(+), 43 deletions(-)

With 2 small comments...

2 ? or 1 ?

Two, with one in the commit log above :)

Oops, sorry I missed it. yeah, the comment above is my mistake. I'll fix it.

Thanks!


-- 
Masami Hiramatsu [off-list ref]