[PATCH 03/11] macintosh/via-pmu: Don't clear shift register interrupt flag twice
From: Finn Thain <hidden>
Date: 2018-06-02 03:28:00
Also in:
lkml
Subsystem:
linux for power macintosh, the rest · Maintainer:
Linus Torvalds
Clearing the interrupt flag twice in succession creates a theoretical race condition. Fix this. Tested-by: Stan Johnson <redacted> Signed-off-by: Finn Thain <redacted> --- drivers/macintosh/via-pmu.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 9c94f99e80da..087c3aa5233a 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c@@ -1458,7 +1458,6 @@ pmu_sr_intr(void) if (in_8(&via[B]) & TREQ) { printk(KERN_ERR "PMU: spurious SR intr (%x)\n", in_8(&via[B])); - out_8(&via[IFR], SR_INT); return NULL; } /* The ack may not yet be low when we get the interrupt */
--
2.16.1