Thread (5 messages) 5 messages, 3 authors, 2018-05-25

Re: [1/2] powerpc/xmon: Specify the full format in DUMP() macro

From: Michael Ellerman <hidden>
Date: 2018-05-25 11:41:52

On Wed, 2018-05-23 at 11:48:36 UTC, Michael Ellerman wrote:
In dump_one_paca() the DUMP macro unconditionally prepends '#' to the
printf format specifier. In most cases we're using either 'x' or 'lx'
etc. and that is OK. But for 'p' and other formats using '#' is
actually undefined, and once we enable printf() checking for
xmon_printf() we will get warnings from the compiler.

So just have each usage specify the full format, that way we can omit
'#' when it's inappropriate.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Mathieu Malaterre <redacted>
Applied to powerpc next.

https://git.kernel.org/powerpc/c/6671683db8540e5766f44a1089549c

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help