Re: [PATCH v3 3/4] powerpc/kbuild: Use flags variables rather than overriding LD/CC/AS

On Tue, 15 May 2018 15:24:21 +1000
Michael Ellerman [off-list ref] wrote:

Steven Rostedt [off-list ref] writes:

quoted

On Mon, 14 May 2018 13:52:27 +1000
Nicholas Piggin [off-list ref] wrote:  

quoted

The powerpc toolchain can compile combinations of 32/64 bit and
big/little endian, so it's convenient to consider, e.g.,

  `CC -m64 -mbig-endian`

To be the C compiler for the purpose of invoking it to build target
artifacts. So overriding the the CC variable to include thse
flags  

...

quoted

quoted

diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
index 191eb949d52c..3c67304a7425 100755
--- a/scripts/recordmcount.pl
+++ b/scripts/recordmcount.pl

@@ -274,6 +274,13 @@ if ($arch eq "x86_64") {
     if ($bits == 64) {
 	$type = ".quad";
     }
+    if ($endian eq "big") {
+	    $cc .= " -mbig-endian ";
+	    $ld .= " -EB ";
+    } else {
+	    $cc .= " -mlittle-endian ";
+	    $ld .= " -EL ";
+    }  

Have you tried building all current archs with function tracing
enabled to make sure this doesn't break any of them? I can do it if
you want.  

We shouldn't need to should we? This is only touching powerpc specific
code (if I understand perl that is).

Yeah that wasn't clear from the diff context, it should only have an
affect on powerpc so you shouldn't need to go through other archs.

Thanks,
Nick