Thread (4 messages) flat view 4 messages, 4 authors, 2018-05-10

Re: [PATCH] powerpc/pseries: hcall_exit tracepoint retval should be signed

From: Ravi Bangoria <hidden>
Date: 2018-05-09 09:47:00


On 05/07/2018 06:33 PM, Michael Ellerman wrote:
The hcall_exit() tracepoint has retval defined as unsigned long. That
leads to humours results like:

  bash-3686  [009] d..2   854.134094: hcall_entry: opcode=24
  bash-3686  [009] d..2   854.134095: hcall_exit: opcode=24 retval=18446744073709551609

It's normal for some hcalls to return negative values, displaying them
as unsigned isn't very helpful. So change it to signed.

  bash-3711  [001] d..2   471.691008: hcall_entry: opcode=24
  bash-3711  [001] d..2   471.691008: hcall_exit: opcode=24 retval=-7

Which can be more easily compared to H_NOT_FOUND in hvcall.h
Tested-by: Ravi Bangoria <redacted>

Thank,
Ravi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help