Re: [PATCH 03/13] powerpc/eeh: Fix use-after-release of EEH driver

On Fri, May 04, 2018 at 12:56:55PM +1000, Michael Ellerman wrote:

Sam Bobroff [off-list ref] writes:

quoted

Correct two cases where eeh_pcid_get() is used to reference the driver's
module but the reference is dropped before the driver pointer is used.

In eeh_rmv_device() also refactor a little so that only two calls to
eeh_pcid_put() are needed, rather than three and the reference isn't
taken at all if it wasn't needed.

This sounds like a crash or memory corruption bug?

But it doesn't have Fixes or Cc: stable. Is it not a major problem for
some reason?

Only that I've exercised that code path a fair bit during testing and
never managed to cause a problem with it. I found it by inspection.

Do you think I should mark it fixes or stable in the next version?

cheers