Re: [PATCH 3/4] powerpc/perf: Return appropriate value for unknown domain
From: Madhavan Srinivasan <hidden>
Date: 2018-05-03 03:32:39
On Monday 09 April 2018 02:30 PM, Anju T Sudhakar wrote:
Return proper error code for unknown domain during IMC initialization.
Looks good to me. Reviewed-by: Madhavan Srinivasan <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Anju T Sudhakar <redacted> --- arch/powerpc/perf/imc-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c index 1b285cd..4b4ca83 100644 --- a/arch/powerpc/perf/imc-pmu.c +++ b/arch/powerpc/perf/imc-pmu.c@@ -1371,7 +1371,7 @@ int init_imc_pmu(struct device_node *parent, struct imc_pmu *pmu_ptr, int pmu_id break; default: - return -1; /* Unknown domain */ + return -EINVAL; /* Unknown domain */ } ret = update_events_in_group(parent, pmu_ptr);