Re: [PATCH kernel 2/2] KVM: PPC: Allow backing bigger guest IOMMU pages with smaller physical pages

On Wed, May 02, 2018 at 04:26:04PM +1000, Alexey Kardashevskiy wrote:

On 2/5/18 3:53 pm, Balbir Singh wrote:

quoted

On Wed,  2 May 2018 14:07:23 +1000
Alexey Kardashevskiy [off-list ref] wrote:

[snip]

quoted

quoted

+	unsigned long subpg;

Why not just i?

I can imagine pages so huge so backing them with 4K will overflow 32bit
anyway. It is very (very) unlikely but it is 64bit arch anyway and there is
no much point in not-long types anyway.

I think Balbir was talking about the variable name, not the type.
i.e. "Why not call it 'i' the default name for a random loop
counter?".

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson