On Thu, Apr 19, 2018 at 12:57 AM, Matthew Wilcox [off-list ref] wrote:

On Thu, Apr 19, 2018 at 12:34:15AM +0530, Souptick Joarder wrote:

quoted

quoted

Re-reading spufs_ps_fault(), I wouldn't change anything inside it.  Just
change its return type to vm_fault_t and call it done.

In that case, return value of spufs_wait() has to changed
to VM_FAULT_ type and we end with changing all the
references where spufs_wait() is called. I think we shouldn't
go with that approach. That's the reason I introduce inline
vmf_handle_error() and convert err to VM_FAULT_ type.

No, don't change the type of 'ret' or spufs_wait.  Just do this:

-static int spufs_ps_fault(struct vm_fault *vmf,
+static vm_fault_t spufs_ps_fault(struct vm_fault *vmf,
                                    unsigned long ps_offs,
                                    unsigned long ps_size)

Agree. but vm_insert_pfn should be replaced with new
vmf_insert_pfn, right ?