Re: drivers: macintosh: rack-meter: really fix bogus memsets
From: Michael Ellerman <hidden>
Date: 2018-03-31 14:04:00
From: Michael Ellerman <hidden>
Date: 2018-03-31 14:04:00
On Fri, 2018-03-16 at 20:17:28 UTC, Aaro Koskinen wrote:
We should zero an array using sizeof instead of number of elements.
Fixes the following compiler (GCC 7.3.0) warnings:
drivers/macintosh/rack-meter.c: In function 'rackmeter_do_pause':
drivers/macintosh/rack-meter.c:157:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
drivers/macintosh/rack-meter.c:158:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
Fixes: 4f7bef7a9f69 ("drivers: macintosh: rack-meter: fix bogus memsets")
Reported-by: Stephen Rothwell <redacted>
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/e283655b5abe26462d53d5196f186c cheers