Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again
From: Michal Suchánek <hidden>
Date: 2018-03-13 17:59:22
From: Michal Suchánek <hidden>
Date: 2018-03-13 17:59:22
On Tue, 13 Mar 2018 09:14:39 -0300 Mauricio Faria de Oliveira [off-list ref] wrote:
Hi Michael, =20 On 03/13/2018 08:39 AM, Michael Ellerman wrote:quoted
quoted
I agree; the 'Using fallback displacement flush' message is misleading (is the system slower/fallback or not? =C3=94_o) =20=20quoted
That message is actually just wrong. =20 It still prints that even if enable=3Dfalse. =20 So we should change all those messages, perhaps: =20 pr_info("rfi-flush: fallback displacement flush available\n"); pr_info("rfi-flush: ori type flush available\n"); pr_info("rfi-flush: mttrig type flush available\n"); =20=20 Indeed.
Maybe it would make more sense to move the messages to the function that actually patches in the instructions? Thanks Michal