Re: [PATCH 2/6] libnvdimm: Add nd_region_destroy()
From: Balbir Singh <bsingharora@gmail.com>
Date: 2018-03-25 23:24:46
Also in:
linux-devicetree, nvdimm
On Fri, 23 Mar 2018 19:12:05 +1100 Oliver O'Halloran [off-list ref] wrote:
quoted hunk
Currently there's no way to remove a region from and nvdimm_bus without tearing down the whole bus. This patch adds an API for removing a single region from the bus so that we can implement a sensible unbind operation for the of_nd_region platform driver. Signed-off-by: Oliver O'Halloran <oohall@gmail.com> --- drivers/nvdimm/region_devs.c | 6 ++++++ include/linux/libnvdimm.h | 1 + 2 files changed, 7 insertions(+)diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index 2f1d5771100e..76f46fd1fae0 100644 --- a/drivers/nvdimm/region_devs.c +++ b/drivers/nvdimm/region_devs.c@@ -1039,6 +1039,12 @@ struct nd_region *nvdimm_blk_region_create(struct nvdimm_bus *nvdimm_bus, } EXPORT_SYMBOL_GPL(nvdimm_blk_region_create); +void nd_region_destroy(struct nd_region *region) +{ + nd_device_unregister(®ion->dev, ND_SYNC);
child_unregister seems to do the same thing, but is expected to be used as a callback from device_for_each_child() I'd suggest we merge the two and rename child_unregister and nd_region_unregister Balbir Singh.