On Fri, Mar 23, 2018 at 1:19 PM, christophe leroy
[off-list ref] wrote:

Le 22/03/2018 =C3=A0 21:20, Mathieu Malaterre a =C3=A9crit :

quoted

Some functions prototypes were missing for the non-altivec code. Add the
missing prototypes directly in xor_vmx, fix warnings treated as errors
with
W=3D1:

   arch/powerpc/lib/xor_vmx_glue.c:18:6: error: no previous prototype fo=

r

quoted

=E2=80=98xor_altivec_2=E2=80=99 [-Werror=3Dmissing-prototypes]
   arch/powerpc/lib/xor_vmx_glue.c:29:6: error: no previous prototype fo=

r

quoted

=E2=80=98xor_altivec_3=E2=80=99 [-Werror=3Dmissing-prototypes]
   arch/powerpc/lib/xor_vmx_glue.c:40:6: error: no previous prototype fo=

r

quoted

=E2=80=98xor_altivec_4=E2=80=99 [-Werror=3Dmissing-prototypes]
   arch/powerpc/lib/xor_vmx_glue.c:52:6: error: no previous prototype fo=

r

quoted

=E2=80=98xor_altivec_5=E2=80=99 [-Werror=3Dmissing-prototypes]

Signed-off-by: Mathieu Malaterre <redacted>
---
  arch/powerpc/lib/xor_vmx.h | 14 ++++++++++++++
  1 file changed, 14 insertions(+)

diff --git a/arch/powerpc/lib/xor_vmx.h b/arch/powerpc/lib/xor_vmx.h
index 5c2b0839b179..2173e3c84151 100644
--- a/arch/powerpc/lib/xor_vmx.h
+++ b/arch/powerpc/lib/xor_vmx.h

@@ -19,3 +19,17 @@ void __xor_altivec_4(unsigned long bytes, unsigned lo=

ng

quoted

*v1_in,
  void __xor_altivec_5(unsigned long bytes, unsigned long *v1_in,
                             unsigned long *v2_in, unsigned long *v3_in,
                             unsigned long *v4_in, unsigned long *v5_in)=

;

quoted

+
+void xor_altivec_2(unsigned long bytes, unsigned long *v1_in,
+                            unsigned long *v2_in);
+

Only used in one place, should be static instead of adding it in a .h

Same for the other ones.

$ git grep xor_altivec_2
[...]
arch/powerpc/lib/xor_vmx_glue.c:EXPORT_SYMBOL(xor_altivec_2);

Are you sure I can change this function to static ?

Christophe

quoted

+void xor_altivec_3(unsigned long bytes, unsigned long *v1_in,
+                            unsigned long *v2_in, unsigned long *v3_in)=

;

quoted

+
+void xor_altivec_4(unsigned long bytes, unsigned long *v1_in,
+                            unsigned long *v2_in, unsigned long *v3_in,
+                            unsigned long *v4_in);
+
+void xor_altivec_5(unsigned long bytes, unsigned long *v1_in,
+                            unsigned long *v2_in, unsigned long *v3_in,
+                            unsigned long *v4_in, unsigned long *v5_in)=

;

quoted

---
L'absence de virus dans ce courrier =C3=A9lectronique a =C3=A9t=C3=A9 v=

=C3=A9rifi=C3=A9e par le

logiciel antivirus Avast.
https://www.avast.com/antivirus