Re: [PATCH] powerpc: Use common error handling code in setup_new_fdt()

Joe Perches [off-list ref] writes:

On Thu, 2018-03-15 at 14:57 +0300, Dan Carpenter wrote:

quoted

On Wed, Mar 14, 2018 at 06:22:07PM -0300, Thiago Jung Bauermann wrote:

quoted

SF Markus Elfring [off-list ref] writes:

quoted

From: Markus Elfring <redacted>
Date: Sun, 11 Mar 2018 09:03:42 +0100

Add a jump target so that a bit of exception handling can be better reused
at the end of this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 arch/powerpc/kernel/machine_kexec_file_64.c | 28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)

I liked it. Thanks!

Reviewed-by: Thiago Jung Bauermann <redacted>

You know that compilers already re-use string constants so this doesn't
actually save memory?

And modern compilers create their own jump labels
so this doesn't change object code either?

I must have missed the memo about us only changing source code if it
results in better object code.

cheers