Re: [PATCH v12 07/22] selftests/vm: fixed bugs in pkey_disable_clear()

From
Thiago Jung Bauermann <hidden>
Date
2018-03-28 23:52:00
Also in
linux-arch, linux-doc, linux-kselftest, linux-mm, lkml
Reply to
Dave Hansen, 2018-03-28
Dave Hansen [off-list ref] writes:
On 03/28/2018 01:47 PM, Thiago Jung Bauermann wrote:
quoted
quoted
quoted
 	if (flags)
-		assert(rdpkey_reg() > orig_pkey_reg);
+		assert(rdpkey_reg() < orig_pkey_reg);
 }

 void pkey_write_allow(int pkey)
This seems so horribly wrong that I wonder how it worked in the first
place.  Any idea?
The code simply wasn't used. pkey_disable_clear() is called by
pkey_write_allow() and pkey_access_allow(), but before this patch series
nothing called either of these functions.
Ahh, that explains it.  Can that get stuck in the changelog, please?
Yes, will be in the next version.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center
Thread (49 messages) 49 messages, 5 authors, last reply 2018-03-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help