Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
From: William Breathitt Gray <hidden>
Date: 2018-02-20 12:50:07
Also in:
linux-amlogic, linux-mediatek, linux-mips, linux-samsung-soc, linux-tegra, linux-watchdog
On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote:
- Add SPDX identifier - Remove boiler plate license text - If MODULE_LICENSE and boiler plate does not match, go for boiler plate license Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> Acked-by: Adam Thomson <redacted> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Acked-by: Michal Simek <redacted> --- Notes: v2: - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt - Change to BSD-3-Clause for meson_gxbb_wdt v1: Please have an extra look at meson_gxbb_wdt.c
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c index 2170b275ea01..c173b6f5c866 100644 --- a/drivers/watchdog/ebc-c384_wdt.c +++ b/drivers/watchdog/ebc-c384_wdt.c@@ -1,15 +1,8 @@ +// SPDX-License-Identifier: GPL-2.0/* * Watchdog timer driver for the WinSystems EBC-C384 * Copyright (C) 2016 William Breathitt Gray * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License, version 2, as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. */ #include <linux/device.h> #include <linux/dmi.h>
I have no problem with adding a SPDX line to the top of this file, but
use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional
with the selection of GPL version 2 only when I published this code.
Furthermore, please do not remove the existing copyright text; although
it's just boilerplate for some, I was careful with the selection of
these words, and I worry the SPDX line only -- despite its useful
conciseness -- may lead to misunderstandings about my intentioned
license for this code.
For the time being, I can't Ack this patch with the changes it makes
currently:
Nacked-by: William Breathitt Gray [off-list ref]
William Breathitt Gray