Thread (5 messages) flat view 5 messages, 4 authors, 2018-02-15

Re: [PATCH] cxl: Remove function write_timebase_ctrl_psl9() for PSL9

From: Vaibhav Jain <hidden>
Date: 2018-02-15 06:03:54

Frederic Barrat [off-list ref] writes:
The code change looks ok, but am I the only one to think the commit 
message doesn't match? The enable bit has always been in the PSL_CONTROL 
register, it was just badly documented on p8. What's been removed is 
much of the configuration found in PSL_TB_CTLSTAT.
Thanks for pointing this out Fred. I wrongly assumed looking at the PSL8
implementation that writing to the PSL_TV_CTLSTAT regiser enabled the
TB. I will update the patch description and resend the patch.

-- 
Vaibhav Jain [off-list ref]
Linux Technology Center, IBM India Pvt. Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help