Thread (16 messages) 16 messages, 4 authors, 2018-03-18

Re: [PATCH 4/5] mtd: Unconditionally update ->fail_addr and ->addr in part_erase()

From: Richard Weinberger <richard@nod.at>
Date: 2018-02-12 22:04:08
Also in: netdev

Am Montag, 12. Februar 2018, 22:03:10 CET schrieb Boris Brezillon:
->fail_addr and ->addr can be updated no matter the result of
parent->_erase(), we just need to remove the code doing the same thing
in mtd_erase_callback() to avoid adjusting those fields twice.

Note that this can be done because all MTD users have been converted to
not pass an erase_info->callback() and are thus only taking the
->addr_fail and ->addr fields into account after part_erase() has
returned.

While we're at it, get rid of the erase_info->mtd field which was only
needed to let mtd_erase_callback() get the partition device back.

Signed-off-by: Boris Brezillon <redacted>
Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help