Thread (14 messages) 14 messages, 11 authors, 2018-02-24

Re: [PATCH] fix double ;;s in code

From: Alex Deucher <hidden>
Date: 2018-02-20 16:34:20
Also in: amd-gfx, dri-devel, linux-arm-msm, linux-block, linux-efi, linux-iommu, linux-raid

On Tue, Feb 20, 2018 at 3:03 AM, Jani Nikula
[off-list ref] wrote:
On Mon, 19 Feb 2018, Pavel Machek [off-list ref] wrote:
quoted
On Mon 2018-02-19 16:41:35, Daniel Vetter wrote:
quoted
Yeah, pls split this into one patch per area, with a suitable patch
subject prefix. Look at git log of each file to get a feeling for what's
the standard in each area.
Yeah I can spend hour spliting it, and then people will ignore it
anyway.

If you care about one of the files being modified, please fix the
bug, ";;" is a clear bug.

If you don't care ... well I don't care either.
Look, if this causes just one conflict down the line because it touches
the kernel all over the place, then IMO it already wasn't worth
it. Merge conflicts are inevitable, but there's no reason to make life
harder just to cater for a cleanup patch. It's not that important.

Had it been split up, the drm parts would've been merged already.
FWIW, the amdgpu and scheduler changes have already been fixed for -next.

Alex
BR,
Jani.

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help