[PATCH] powerpc/time: stop validating rtc_time in .read_time

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3063d

2 messages, 2 authors, 2018-03-19 · open the first message on its own page

[PATCH] powerpc/time: stop validating rtc_time in .read_time

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: 2018-02-21 21:46:37

The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 arch/powerpc/kernel/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
index a32823dcd9a4..f7d96a68ecaa 100644
--- a/arch/powerpc/kernel/time.c
+++ b/arch/powerpc/kernel/time.c
@@ -1234,7 +1234,7 @@ void calibrate_delay(void)
 static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm)
 {
 	ppc_md.get_rtc_time(tm);
-	return rtc_valid_tm(tm);
+	return 0;
 }
 
 static int rtc_generic_set_time(struct device *dev, struct rtc_time *tm)
-- 
2.16.1

Re: powerpc/time: stop validating rtc_time in .read_time

From: Michael Ellerman <hidden>
Date: 2018-03-19 22:23:06

On Wed, 2018-02-21 at 21:46:33 UTC, Alexandre Belloni wrote:
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/890ae7979758568734881ad0f382c4

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help